QT/C++ Server Login System

[maboroshi]

Hey everyone as part of a current project I am building a Server Login System this is far from complete.

I would like suggestions possibly with code either based on my code or a rewrite of my code on how to handle the login, cause criminey I can't figure it out.

Gogeta gave me pseudo code to follow from, but hell if I could understand all of what it said.

Anyone with advice please post (Cats, Anyone Else)

I will post the relevant parts of my code but it is far from being efficient

Then client sends this

Code: Select all

QByteArray Buffer;
Buffer.append("0" + username->text() + "@" + password->text());
socket->write(Buffer);

*cheers and thanks for any help

Mabo

[maboroshi]

NOT SOLVED

[ayu]

ah, gj!

[maboroshi]

Actually that code I posted second didn't work quite as expected

The first code was more accurate but I learned some things

*cheers

Mabo

[Lundis]

This is a completely random remark on your code.

QByteArray Server::getPart(const QByteArray message, int part, bool toEnd)

You're using const there to hopefully let the compiler optimize stuff, but unfortunately using const like that should only have compile-time benefits (you cant accidentally modify it). To save memory and time, you should use a const reference instead:

QByteArray Server::getPart(const QByteArray& message, int part, bool toEnd)

This wont copy the QByteArray, and it doesn't change the syntax anywhere else at all. It's a very common practice in C++, for avoiding the copying of large data structures.

[Gogeta70]

This is a completely random remark on your code.

QByteArray Server::getPart(const QByteArray message, int part, bool toEnd)

You're using const there to hopefully let the compiler optimize stuff, but unfortunately using const like that should only have compile-time benefits (you cant accidentally modify it). To save memory and time, you should use a const reference instead:

QByteArray Server::getPart(const QByteArray& message, int part, bool toEnd)

This wont copy the QByteArray, and it doesn't change the syntax anywhere else at all. It's a very common practice in C++, for avoiding the copying of large data structures.

This is a good point. In fact, it's something i often forget to do in my code as well. I generally don't optimize my existing code unless it's showing signs that it needs it though.